yann@1
|
1 |
Fixes
|
yann@1
|
2 |
dl-runtime.c:56: error: conflicting types for 'fixup'
|
yann@1
|
3 |
../sysdeps/i386/dl-machine.h:158: error: previous declaration of 'fixup' was here
|
yann@1
|
4 |
when building with gcc-3.4.0
|
yann@1
|
5 |
|
yann@1
|
6 |
First hunk:
|
yann@1
|
7 |
Define ARCH_FIXUP_ATTRIBUTE and use it in the fixup function declarations.
|
yann@1
|
8 |
http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/sysdeps/i386/dl-machine.h.diff?r1=1.124&r2=1.125&cvsroot=glibc
|
yann@1
|
9 |
[rediffed against glibc-2.1.3]
|
yann@1
|
10 |
|
yann@1
|
11 |
Second hunk:
|
yann@1
|
12 |
If ARCH_FIXUP_ATTRIBUTE is not defined, provide dummy definition.
|
yann@1
|
13 |
Use macro in fixup function definitions.
|
yann@1
|
14 |
http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/elf/dl-runtime.c.diff?r1=1.64&r2=1.65&cvsroot=glibc
|
yann@1
|
15 |
[rediffed against glibc-2.3.2]
|
yann@1
|
16 |
|
yann@1
|
17 |
===================================================================
|
yann@1
|
18 |
--- glibc-2.1.3/sysdeps/i386/dl-machine.h.old Sun Apr 11 18:58:45 2004
|
yann@1
|
19 |
+++ glibc-2.1.3/sysdeps/i386/dl-machine.h Sun Apr 11 18:59:51 2004
|
yann@1
|
20 |
@@ -70,11 +70,14 @@
|
yann@1
|
21 |
|
yann@1
|
22 |
We cannot use this scheme for profiling because the _mcount call
|
yann@1
|
23 |
destroys the passed register information. */
|
yann@1
|
24 |
+
|
yann@1
|
25 |
+#define ARCH_FIXUP_ATTRIBUTE __attribute__ ((regparm (3), unused))
|
yann@1
|
26 |
+
|
yann@1
|
27 |
static ElfW(Addr) fixup (struct link_map *l, ElfW(Word) reloc_offset)
|
yann@1
|
28 |
- __attribute__ ((regparm (2), unused));
|
yann@1
|
29 |
+ ARCH_FIXUP_ATTRIBUTE;
|
yann@1
|
30 |
static ElfW(Addr) profile_fixup (struct link_map *l, ElfW(Word) reloc_offset,
|
yann@1
|
31 |
ElfW(Addr) retaddr)
|
yann@1
|
32 |
- __attribute__ ((regparm (3), unused));
|
yann@1
|
33 |
+ ARCH_FIXUP_ATTRIBUTE;
|
yann@1
|
34 |
#endif
|
yann@1
|
35 |
|
yann@1
|
36 |
/* Set up the loaded object described by L so its unrelocated PLT
|
yann@1
|
37 |
===================================================================
|
yann@1
|
38 |
--- glibc-2.1.3/elf/dl-runtime.c~ Thu Jul 15 11:32:41 1999
|
yann@1
|
39 |
+++ glibc-2.1.3/elf/dl-runtime.c Sun Apr 11 19:02:01 2004
|
yann@1
|
40 |
@@ -31,6 +31,12 @@
|
yann@1
|
41 |
# define VERSYMIDX(sym) (DT_NUM + DT_PROCNUM + DT_VERSIONTAGIDX (sym))
|
yann@1
|
42 |
#endif
|
yann@1
|
43 |
|
yann@1
|
44 |
+/* The fixup functions might have need special attributes. If none
|
yann@1
|
45 |
+ are provided define the macro as empty. */
|
yann@1
|
46 |
+#ifndef ARCH_FIXUP_ATTRIBUTE
|
yann@1
|
47 |
+# define ARCH_FIXUP_ATTRIBUTE
|
yann@1
|
48 |
+#endif
|
yann@1
|
49 |
+
|
yann@1
|
50 |
|
yann@1
|
51 |
/* This function is called through a special trampoline from the PLT the
|
yann@1
|
52 |
first time each PLT entry is called. We must perform the relocation
|
yann@1
|
53 |
@@ -40,7 +46,7 @@
|
yann@1
|
54 |
function. */
|
yann@1
|
55 |
|
yann@1
|
56 |
#ifndef ELF_MACHINE_NO_PLT
|
yann@1
|
57 |
-static ElfW(Addr) __attribute__ ((unused))
|
yann@1
|
58 |
+static ElfW(Addr) __attribute__ ((unused)) ARCH_FIXUP_ATTRIBUTE
|
yann@1
|
59 |
fixup (
|
yann@1
|
60 |
# ifdef ELF_MACHINE_RUNTIME_FIXUP_ARGS
|
yann@1
|
61 |
ELF_MACHINE_RUNTIME_FIXUP_ARGS,
|
yann@1
|
62 |
@@ -105,7 +111,7 @@
|
yann@1
|
63 |
|
yann@1
|
64 |
#if !defined PROF && !defined ELF_MACHINE_NO_PLT
|
yann@1
|
65 |
|
yann@1
|
66 |
-static ElfW(Addr) __attribute__ ((unused))
|
yann@1
|
67 |
+static ElfW(Addr) __attribute__ ((unused)) ARCH_FIXUP_ATTRIBUTE
|
yann@1
|
68 |
profile_fixup (
|
yann@1
|
69 |
#ifdef ELF_MACHINE_RUNTIME_FIXUP_ARGS
|
yann@1
|
70 |
ELF_MACHINE_RUNTIME_FIXUP_ARGS,
|