patches/binutils/2.19/150-warn-textrel.patch
author Anthony Foiani <anthony.foiani@gmail.com>
Thu May 19 23:09:43 2011 +0200 (2011-05-19)
branch1.11
changeset 2465 5f98b7a90fbc
permissions -rw-r--r--
complibs/ppl: fix 0.11-0.11.2 to compile with --disable-shared

PPL 0.11 (through 0.11.2) had a small bug where it still tried to build
and test its Java interface even when shared libraries are disabled.
Since that's exactly what ct-ng does, it explodes.

This is the patch from the PPL authors (see final link below).

More information can be found in these messages/threads:

Anthony's initial report and analysis with Yann:
http://www.cygwin.com/ml/crossgcc/2011-05/msg00046.html

Ron Flory hit the same problem:
http://www.cygwin.com/ml/crossgcc/2011-05/msg00054.html

Anthony's report to the ppl-devel list:
http://www.cs.unipr.it/pipermail/ppl-devel/2011-May/017450.html

Roberto's reply with a link to the fix in the PPL git repo:
http://www.cs.unipr.it/pipermail/ppl-devel/2011-May/017455.html

Signed-Off-By: Anthony Foiani <anthony.foiani@gmail.com>
(transplanted from 139b85d70b623e51f7585e7c64ecb8c6a6cf4567)
yann@1069
     1
Original patch from Gentoo:
yann@1069
     2
gentoo/src/patchsets/binutils/2.19/66_all_binutils-2.18.50.0.2-warn-textrel.patch
yann@1069
     3
yann@1069
     4
textrels are bad for forcing copy-on-write (this affects everyone),
yann@1069
     5
and for security/runtime code generation, this affects security ppl.
yann@1069
     6
But in either case, it doesn't matter who needs textrels, it's
yann@1069
     7
the very fact that they're needed at all.
yann@1069
     8
yann@1069
     9
diff -durN binutils-2.19.orig/bfd/elflink.c binutils-2.19/bfd/elflink.c
yann@1069
    10
--- binutils-2.19.orig/bfd/elflink.c	2008-11-23 16:49:47.000000000 +0100
yann@1069
    11
+++ binutils-2.19/bfd/elflink.c	2008-11-23 16:49:14.000000000 +0100
yann@1069
    12
@@ -10820,14 +10820,12 @@
yann@1069
    13
 	goto error_return;
yann@1069
    14
 
yann@1069
    15
       /* Check for DT_TEXTREL (late, in case the backend removes it).  */
yann@1069
    16
-      if (info->warn_shared_textrel && info->shared)
yann@1069
    17
+      o = bfd_get_section_by_name (dynobj, ".dynamic");
yann@1069
    18
+      if (info->warn_shared_textrel && o != NULL)
yann@1069
    19
 	{
yann@1069
    20
 	  bfd_byte *dyncon, *dynconend;
yann@1069
    21
 
yann@1069
    22
 	  /* Fix up .dynamic entries.  */
yann@1069
    23
-	  o = bfd_get_section_by_name (dynobj, ".dynamic");
yann@1069
    24
-	  BFD_ASSERT (o != NULL);
yann@1069
    25
-
yann@1069
    26
 	  dyncon = o->contents;
yann@1069
    27
 	  dynconend = o->contents + o->size;
yann@1069
    28
 	  for (; dyncon < dynconend; dyncon += bed->s->sizeof_dyn)
yann@1069
    29
@@ -10839,7 +10837,7 @@
yann@1069
    30
 	      if (dyn.d_tag == DT_TEXTREL)
yann@1069
    31
 		{
yann@1069
    32
 		 info->callbacks->einfo
yann@1069
    33
-		    (_("%P: warning: creating a DT_TEXTREL in a shared object.\n"));
yann@1069
    34
+		    (_("%P: warning: creating a DT_TEXTREL in object.\n"));
yann@1069
    35
 		  break;
yann@1069
    36
 		}
yann@1069
    37
 	    }
yann@1069
    38
diff -durN binutils-2.19.orig/ld/ldmain.c binutils-2.19/ld/ldmain.c
yann@1069
    39
--- binutils-2.19.orig/ld/ldmain.c	2008-08-17 05:12:50.000000000 +0200
yann@1069
    40
+++ binutils-2.19/ld/ldmain.c	2008-11-23 16:52:37.000000000 +0100
yann@1069
    41
@@ -274,6 +274,7 @@
yann@1069
    42
   link_info.relax_pass = 1;
yann@1069
    43
   link_info.pei386_auto_import = -1;
yann@1069
    44
   link_info.spare_dynamic_tags = 5;
yann@1069
    45
+  link_info.warn_shared_textrel = TRUE;
yann@1069
    46
   link_info.path_separator = ':';
yann@1069
    47
 
yann@1069
    48
   ldfile_add_arch ("");