|
yann@402
|
1 |
Retrieved from http://sources.redhat.com/ml/binutils/2004-04/msg00646.html
|
|
yann@402
|
2 |
Fixes
|
|
yann@402
|
3 |
localealias.s:544: Error: junk at end of line, first unrecognized character is `,'
|
|
yann@402
|
4 |
when building glibc-2.3.2 with gcc-3.4.0 and binutils-2.15.90.0.3
|
|
yann@402
|
5 |
|
|
yann@402
|
6 |
Paths adjusted to match crosstool's patcher.
|
|
yann@402
|
7 |
|
|
yann@402
|
8 |
Message-Id: m3n052qw2g.fsf@whitebox.m5r.de
|
|
yann@402
|
9 |
From: Andreas Schwab <schwab at suse dot de>
|
|
yann@402
|
10 |
To: Nathan Sidwell <nathan at codesourcery dot com>
|
|
yann@402
|
11 |
Cc: Ian Lance Taylor <ian at wasabisystems dot com>, binutils at sources dot redhat dot com
|
|
yann@402
|
12 |
Date: Fri, 23 Apr 2004 22:27:19 +0200
|
|
yann@402
|
13 |
Subject: Re: demand_empty_rest_of_line and ignore_rest_of_line
|
|
yann@402
|
14 |
|
|
yann@402
|
15 |
Nathan Sidwell <nathan@codesourcery.com> writes:
|
|
yann@402
|
16 |
|
|
yann@402
|
17 |
> Index: read.c
|
|
yann@402
|
18 |
> ===================================================================
|
|
yann@402
|
19 |
> RCS file: /cvs/src/src/gas/read.c,v
|
|
yann@402
|
20 |
> retrieving revision 1.76
|
|
yann@402
|
21 |
> diff -c -3 -p -r1.76 read.c
|
|
yann@402
|
22 |
> *** read.c 12 Mar 2004 17:48:12 -0000 1.76
|
|
yann@402
|
23 |
> --- read.c 18 Mar 2004 09:56:05 -0000
|
|
yann@402
|
24 |
> *************** read_a_source_file (char *name)
|
|
yann@402
|
25 |
> *** 1053,1059 ****
|
|
yann@402
|
26 |
> #endif
|
|
yann@402
|
27 |
> input_line_pointer--;
|
|
yann@402
|
28 |
> /* Report unknown char as ignored. */
|
|
yann@402
|
29 |
> ! ignore_rest_of_line ();
|
|
yann@402
|
30 |
> }
|
|
yann@402
|
31 |
>
|
|
yann@402
|
32 |
> #ifdef md_after_pass_hook
|
|
yann@402
|
33 |
> --- 1053,1059 ----
|
|
yann@402
|
34 |
> #endif
|
|
yann@402
|
35 |
> input_line_pointer--;
|
|
yann@402
|
36 |
> /* Report unknown char as ignored. */
|
|
yann@402
|
37 |
> ! demand_empty_rest_of_line ();
|
|
yann@402
|
38 |
> }
|
|
yann@402
|
39 |
>
|
|
yann@402
|
40 |
> #ifdef md_after_pass_hook
|
|
yann@402
|
41 |
|
|
yann@402
|
42 |
This means that the unknown character is no longer ignored, despite the
|
|
yann@402
|
43 |
comment. As a side effect a line starting with a line comment character
|
|
yann@402
|
44 |
not followed by APP in NO_APP mode now triggers an error instead of just a
|
|
yann@402
|
45 |
warning, breaking builds of glibc on m68k-linux. Earlier in
|
|
yann@402
|
46 |
read_a_source_file where #APP is handled there is another comment that
|
|
yann@402
|
47 |
claims that unknown comments are ignored, when in fact they aren't (only
|
|
yann@402
|
48 |
the initial line comment character is skipped).
|
|
yann@402
|
49 |
|
|
yann@402
|
50 |
Note that the presence of #APP will mess up the line counters, but
|
|
yann@402
|
51 |
that appears to be difficult to fix.
|
|
yann@402
|
52 |
|
|
yann@402
|
53 |
Andreas.
|
|
yann@402
|
54 |
|
|
yann@402
|
55 |
2004-04-23 Andreas Schwab <schwab@suse.de>
|
|
yann@402
|
56 |
|
|
yann@402
|
57 |
* read.c (read_a_source_file): Ignore unknown text after line
|
|
yann@402
|
58 |
comment character. Fix misleading comment.
|
|
yann@402
|
59 |
|
|
yann@402
|
60 |
--- binutils/gas/read.c.~1.78.~ 2004-04-23 08:58:23.000000000 +0200
|
|
yann@402
|
61 |
+++ binutils/gas/read.c 2004-04-23 21:49:01.000000000 +0200
|
|
yann@402
|
62 |
@@ -1,6 +1,6 @@
|
|
yann@402
|
63 |
/* read.c - read a source file -
|
|
yann@402
|
64 |
Copyright 1986, 1987, 1990, 1991, 1992, 1993, 1994, 1995, 1996, 1997,
|
|
yann@402
|
65 |
- 1998, 1999, 2000, 2001, 2002, 2003 Free Software Foundation, Inc.
|
|
yann@402
|
66 |
+ 1998, 1999, 2000, 2001, 2002, 2003, 2004 Free Software Foundation, Inc.
|
|
yann@402
|
67 |
|
|
yann@402
|
68 |
This file is part of GAS, the GNU Assembler.
|
|
yann@402
|
69 |
|
|
yann@402
|
70 |
@@ -950,10 +950,14 @@ read_a_source_file (char *name)
|
|
yann@402
|
71 |
unsigned int new_length;
|
|
yann@402
|
72 |
char *tmp_buf = 0;
|
|
yann@402
|
73 |
|
|
yann@402
|
74 |
- bump_line_counters ();
|
|
yann@402
|
75 |
s = input_line_pointer;
|
|
yann@402
|
76 |
if (strncmp (s, "APP\n", 4))
|
|
yann@402
|
77 |
- continue; /* We ignore it */
|
|
yann@402
|
78 |
+ {
|
|
yann@402
|
79 |
+ /* We ignore it */
|
|
yann@402
|
80 |
+ ignore_rest_of_line ();
|
|
yann@402
|
81 |
+ continue;
|
|
yann@402
|
82 |
+ }
|
|
yann@402
|
83 |
+ bump_line_counters ();
|
|
yann@402
|
84 |
s += 4;
|
|
yann@402
|
85 |
|
|
yann@402
|
86 |
sb_new (&sbuf);
|
|
yann@402
|
87 |
@@ -1052,7 +1056,7 @@ read_a_source_file (char *name)
|
|
yann@402
|
88 |
continue;
|
|
yann@402
|
89 |
#endif
|
|
yann@402
|
90 |
input_line_pointer--;
|
|
yann@402
|
91 |
- /* Report unknown char as ignored. */
|
|
yann@402
|
92 |
+ /* Report unknown char as error. */
|
|
yann@402
|
93 |
demand_empty_rest_of_line ();
|
|
yann@402
|
94 |
}
|
|
yann@402
|
95 |
|
|
yann@402
|
96 |
|
|
yann@402
|
97 |
--
|
|
yann@402
|
98 |
Andreas Schwab, SuSE Labs, schwab@suse.de
|
|
yann@402
|
99 |
SuSE Linux AG, MaxfeldstraÃe 5, 90409 NÃrnberg, Germany
|
|
yann@402
|
100 |
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
|
|
yann@402
|
101 |
"And now for something completely different."
|