yann@1
|
1 |
Fixes
|
yann@1
|
2 |
gconv_open.c: In function `__gconv_open':
|
yann@1
|
3 |
gconv_open.c:186: error: invalid lvalue in assignment
|
yann@1
|
4 |
when building glibc-2.3.2 with gcc-3.5.
|
yann@1
|
5 |
|
yann@1
|
6 |
wget 'http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/iconv/gconv_simple.c.diff?r1=1.59&r2=1.63&cvsroot=glibc'
|
yann@1
|
7 |
* (internal_ucs4_loop): Fix typo in last change.
|
yann@1
|
8 |
|
yann@1
|
9 |
* (internal_ucs4le_loop): Remove cast used as lvalue.
|
yann@1
|
10 |
|
yann@1
|
11 |
* Fix last commit.
|
yann@1
|
12 |
|
yann@1
|
13 |
* iconv/gconv_simple.c (ucs4le_internal_loop): Remove cast used as lvalue.
|
yann@1
|
14 |
(internal_ucs4le_loop_single): Likewise.
|
yann@1
|
15 |
(ucs4_internal_loop): Likewise.
|
yann@1
|
16 |
(BODY): Likewise.
|
yann@1
|
17 |
(internal_ucs4_loop_single): Likewise.
|
yann@1
|
18 |
|
yann@1
|
19 |
wget 'http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/iconv/gconv_open.c.diff?r1=1.32&r2=1.33&cvsroot=glibc'
|
yann@1
|
20 |
* iconv/gconv_simple.c (ucs4le_internal_loop): Remove cast used as lvalue.
|
yann@1
|
21 |
(internal_ucs4le_loop_single): Likewise.
|
yann@1
|
22 |
(ucs4_internal_loop): Likewise.
|
yann@1
|
23 |
(BODY): Likewise.
|
yann@1
|
24 |
(internal_ucs4_loop_single): Likewise.
|
yann@1
|
25 |
|
yann@1
|
26 |
|
yann@1
|
27 |
===================================================================
|
yann@1
|
28 |
RCS file: /cvs/glibc/libc/iconv/gconv_open.c,v
|
yann@1
|
29 |
retrieving revision 1.32
|
yann@1
|
30 |
retrieving revision 1.33
|
yann@1
|
31 |
diff -u -r1.32 -r1.33
|
yann@1
|
32 |
--- libc/iconv/gconv_open.c 2001/11/29 04:51:58 1.32
|
yann@1
|
33 |
+++ libc/iconv/gconv_open.c 2004/02/07 15:56:32 1.33
|
yann@1
|
34 |
@@ -1,5 +1,5 @@
|
yann@1
|
35 |
/* Find matching transformation algorithms and initialize steps.
|
yann@1
|
36 |
- Copyright (C) 1997, 1998, 1999, 2000, 2001 Free Software Foundation, Inc.
|
yann@1
|
37 |
+ Copyright (C) 1997, 1998, 1999, 2000, 2001, 2004 Free Software Foundation, Inc.
|
yann@1
|
38 |
This file is part of the GNU C Library.
|
yann@1
|
39 |
Contributed by Ulrich Drepper <drepper@cygnus.com>, 1997.
|
yann@1
|
40 |
|
yann@1
|
41 |
@@ -182,8 +182,13 @@
|
yann@1
|
42 |
|| __builtin_expect (__gconv_translit_find (runp), 0) == 0)
|
yann@1
|
43 |
lastp = runp;
|
yann@1
|
44 |
else
|
yann@1
|
45 |
- /* This means we haven't found the module. Remove it. */
|
yann@1
|
46 |
- (lastp == NULL ? trans : lastp->next) = runp->next;
|
yann@1
|
47 |
+ {
|
yann@1
|
48 |
+ /* This means we haven't found the module. Remove it. */
|
yann@1
|
49 |
+ if (lastp == NULL)
|
yann@1
|
50 |
+ trans = runp->next;
|
yann@1
|
51 |
+ else
|
yann@1
|
52 |
+ lastp->next = runp->next;
|
yann@1
|
53 |
+ }
|
yann@1
|
54 |
}
|
yann@1
|
55 |
|
yann@1
|
56 |
/* Allocate room for handle. */
|
yann@1
|
57 |
===================================================================
|
yann@1
|
58 |
RCS file: /cvs/glibc/libc/iconv/gconv_simple.c,v
|
yann@1
|
59 |
retrieving revision 1.59
|
yann@1
|
60 |
retrieving revision 1.63
|
yann@1
|
61 |
diff -u -r1.59 -r1.63
|
yann@1
|
62 |
--- libc/iconv/gconv_simple.c 2003/06/11 21:36:37 1.59
|
yann@1
|
63 |
+++ libc/iconv/gconv_simple.c 2004/03/09 10:00:31 1.63
|
yann@1
|
64 |
@@ -1,5 +1,5 @@
|
yann@1
|
65 |
/* Simple transformations functions.
|
yann@1
|
66 |
- Copyright (C) 1997-2002, 2003 Free Software Foundation, Inc.
|
yann@1
|
67 |
+ Copyright (C) 1997-2003, 2004 Free Software Foundation, Inc.
|
yann@1
|
68 |
This file is part of the GNU C Library.
|
yann@1
|
69 |
Contributed by Ulrich Drepper <drepper@cygnus.com>, 1997.
|
yann@1
|
70 |
|
yann@1
|
71 |
@@ -87,12 +87,13 @@
|
yann@1
|
72 |
#if __BYTE_ORDER == __LITTLE_ENDIAN
|
yann@1
|
73 |
/* Sigh, we have to do some real work. */
|
yann@1
|
74 |
size_t cnt;
|
yann@1
|
75 |
+ uint32_t *outptr32 = (uint32_t *) outptr;
|
yann@1
|
76 |
|
yann@1
|
77 |
for (cnt = 0; cnt < n_convert; ++cnt, inptr += 4)
|
yann@1
|
78 |
- *((uint32_t *) outptr)++ = bswap_32 (*(const uint32_t *) inptr);
|
yann@1
|
79 |
+ *outptr32++ = bswap_32 (*(const uint32_t *) inptr);
|
yann@1
|
80 |
|
yann@1
|
81 |
*inptrp = inptr;
|
yann@1
|
82 |
- *outptrp = outptr;
|
yann@1
|
83 |
+ *outptrp = (unsigned char *) outptr32;
|
yann@1
|
84 |
#elif __BYTE_ORDER == __BIG_ENDIAN
|
yann@1
|
85 |
/* Simply copy the data. */
|
yann@1
|
86 |
*inptrp = inptr + n_convert * 4;
|
yann@1
|
87 |
@@ -192,13 +193,16 @@
|
yann@1
|
88 |
(*outptrp)[2] = state->__value.__wchb[1];
|
yann@1
|
89 |
(*outptrp)[3] = state->__value.__wchb[0];
|
yann@1
|
90 |
|
yann@1
|
91 |
- *outptrp += 4;
|
yann@1
|
92 |
#elif __BYTE_ORDER == __BIG_ENDIAN
|
yann@1
|
93 |
/* XXX unaligned */
|
yann@1
|
94 |
- *(*((uint32_t **) outptrp)++) = state->__value.__wch;
|
yann@1
|
95 |
+ (*outptrp)[0] = state->__value.__wchb[0];
|
yann@1
|
96 |
+ (*outptrp)[1] = state->__value.__wchb[1];
|
yann@1
|
97 |
+ (*outptrp)[2] = state->__value.__wchb[2];
|
yann@1
|
98 |
+ (*outptrp)[3] = state->__value.__wchb[3];
|
yann@1
|
99 |
#else
|
yann@1
|
100 |
# error "This endianess is not supported."
|
yann@1
|
101 |
#endif
|
yann@1
|
102 |
+ *outptrp += 4;
|
yann@1
|
103 |
|
yann@1
|
104 |
/* Clear the state buffer. */
|
yann@1
|
105 |
state->__count &= ~7;
|
yann@1
|
106 |
@@ -268,7 +272,8 @@
|
yann@1
|
107 |
return __GCONV_ILLEGAL_INPUT;
|
yann@1
|
108 |
}
|
yann@1
|
109 |
|
yann@1
|
110 |
- *((uint32_t *) outptr)++ = inval;
|
yann@1
|
111 |
+ *((uint32_t *) outptr) = inval;
|
yann@1
|
112 |
+ outptr += sizeof (uint32_t);
|
yann@1
|
113 |
}
|
yann@1
|
114 |
|
yann@1
|
115 |
*inptrp = inptr;
|
yann@1
|
116 |
@@ -447,9 +452,11 @@
|
yann@1
|
117 |
#if __BYTE_ORDER == __BIG_ENDIAN
|
yann@1
|
118 |
/* Sigh, we have to do some real work. */
|
yann@1
|
119 |
size_t cnt;
|
yann@1
|
120 |
+ uint32_t *outptr32 = (uint32_t *) outptr;
|
yann@1
|
121 |
|
yann@1
|
122 |
for (cnt = 0; cnt < n_convert; ++cnt, inptr += 4)
|
yann@1
|
123 |
- *((uint32_t *) outptr)++ = bswap_32 (*(const uint32_t *) inptr);
|
yann@1
|
124 |
+ *outptr32++ = bswap_32 (*(const uint32_t *) inptr);
|
yann@1
|
125 |
+ outptr = (unsigned char *) outptr32;
|
yann@1
|
126 |
|
yann@1
|
127 |
*inptrp = inptr;
|
yann@1
|
128 |
*outptrp = outptr;
|
yann@1
|
129 |
@@ -555,12 +562,17 @@
|
yann@1
|
130 |
(*outptrp)[2] = state->__value.__wchb[1];
|
yann@1
|
131 |
(*outptrp)[3] = state->__value.__wchb[0];
|
yann@1
|
132 |
|
yann@1
|
133 |
- *outptrp += 4;
|
yann@1
|
134 |
#else
|
yann@1
|
135 |
/* XXX unaligned */
|
yann@1
|
136 |
- *(*((uint32_t **) outptrp)++) = state->__value.__wch;
|
yann@1
|
137 |
+ (*outptrp)[0] = state->__value.__wchb[0];
|
yann@1
|
138 |
+ (*outptrp)[1] = state->__value.__wchb[1];
|
yann@1
|
139 |
+ (*outptrp)[2] = state->__value.__wchb[2];
|
yann@1
|
140 |
+ (*outptrp)[3] = state->__value.__wchb[3];
|
yann@1
|
141 |
+
|
yann@1
|
142 |
#endif
|
yann@1
|
143 |
|
yann@1
|
144 |
+ *outptrp += 4;
|
yann@1
|
145 |
+
|
yann@1
|
146 |
/* Clear the state buffer. */
|
yann@1
|
147 |
state->__count &= ~7;
|
yann@1
|
148 |
|
yann@1
|
149 |
@@ -626,7 +638,8 @@
|
yann@1
|
150 |
return __GCONV_ILLEGAL_INPUT;
|
yann@1
|
151 |
}
|
yann@1
|
152 |
|
yann@1
|
153 |
- *((uint32_t *) outptr)++ = inval;
|
yann@1
|
154 |
+ *((uint32_t *) outptr) = inval;
|
yann@1
|
155 |
+ outptr += sizeof (uint32_t);
|
yann@1
|
156 |
}
|
yann@1
|
157 |
|
yann@1
|
158 |
*inptrp = inptr;
|
yann@1
|
159 |
@@ -808,7 +821,8 @@
|
yann@1
|
160 |
} \
|
yann@1
|
161 |
else \
|
yann@1
|
162 |
/* It's an one byte sequence. */ \
|
yann@1
|
163 |
- *((uint32_t *) outptr)++ = *inptr++; \
|
yann@1
|
164 |
+ *((uint32_t *) outptr) = *inptr++; \
|
yann@1
|
165 |
+ outptr += sizeof (uint32_t); \
|
yann@1
|
166 |
}
|
yann@1
|
167 |
#define LOOP_NEED_FLAGS
|
yann@1
|
168 |
#include <iconv/loop.c>
|
yann@1
|
169 |
@@ -838,7 +852,8 @@
|
yann@1
|
170 |
} \
|
yann@1
|
171 |
else \
|
yann@1
|
172 |
/* It's an one byte sequence. */ \
|
yann@1
|
173 |
- *outptr++ = *((const uint32_t *) inptr)++; \
|
yann@1
|
174 |
+ *outptr++ = *((const uint32_t *) inptr); \
|
yann@1
|
175 |
+ inptr += sizeof (uint32_t); \
|
yann@1
|
176 |
}
|
yann@1
|
177 |
#define LOOP_NEED_FLAGS
|
yann@1
|
178 |
#include <iconv/loop.c>
|
yann@1
|
179 |
@@ -1032,7 +1047,8 @@
|
yann@1
|
180 |
} \
|
yann@1
|
181 |
\
|
yann@1
|
182 |
/* Now adjust the pointers and store the result. */ \
|
yann@1
|
183 |
- *((uint32_t *) outptr)++ = ch; \
|
yann@1
|
184 |
+ *((uint32_t *) outptr) = ch; \
|
yann@1
|
185 |
+ outptr += sizeof (uint32_t); \
|
yann@1
|
186 |
}
|
yann@1
|
187 |
#define LOOP_NEED_FLAGS
|
yann@1
|
188 |
|
yann@1
|
189 |
@@ -1153,7 +1169,8 @@
|
yann@1
|
190 |
STANDARD_FROM_LOOP_ERR_HANDLER (2); \
|
yann@1
|
191 |
} \
|
yann@1
|
192 |
\
|
yann@1
|
193 |
- *((uint32_t *) outptr)++ = u1; \
|
yann@1
|
194 |
+ *((uint32_t *) outptr) = u1; \
|
yann@1
|
195 |
+ outptr += sizeof (uint32_t); \
|
yann@1
|
196 |
inptr += 2; \
|
yann@1
|
197 |
}
|
yann@1
|
198 |
#define LOOP_NEED_FLAGS
|
yann@1
|
199 |
@@ -1201,7 +1218,8 @@
|
yann@1
|
200 |
} \
|
yann@1
|
201 |
else \
|
yann@1
|
202 |
{ \
|
yann@1
|
203 |
- *((uint16_t *) outptr)++ = val; \
|
yann@1
|
204 |
+ *((uint16_t *) outptr) = val; \
|
yann@1
|
205 |
+ outptr += sizeof (uint16_t); \
|
yann@1
|
206 |
inptr += 4; \
|
yann@1
|
207 |
} \
|
yann@1
|
208 |
}
|
yann@1
|
209 |
@@ -1242,7 +1260,8 @@
|
yann@1
|
210 |
continue; \
|
yann@1
|
211 |
} \
|
yann@1
|
212 |
\
|
yann@1
|
213 |
- *((uint32_t *) outptr)++ = u1; \
|
yann@1
|
214 |
+ *((uint32_t *) outptr) = u1; \
|
yann@1
|
215 |
+ outptr += sizeof (uint32_t); \
|
yann@1
|
216 |
inptr += 2; \
|
yann@1
|
217 |
}
|
yann@1
|
218 |
#define LOOP_NEED_FLAGS
|
yann@1
|
219 |
@@ -1291,7 +1310,8 @@
|
yann@1
|
220 |
} \
|
yann@1
|
221 |
else \
|
yann@1
|
222 |
{ \
|
yann@1
|
223 |
- *((uint16_t *) outptr)++ = bswap_16 (val); \
|
yann@1
|
224 |
+ *((uint16_t *) outptr) = bswap_16 (val); \
|
yann@1
|
225 |
+ outptr += sizeof (uint16_t); \
|
yann@1
|
226 |
inptr += 4; \
|
yann@1
|
227 |
} \
|
yann@1
|
228 |
}
|