patches/gcc/4.4.2/140-default-format-security.patch
author Anthony Foiani <anthony.foiani@gmail.com>
Thu May 19 23:06:16 2011 +0200 (2011-05-19)
changeset 2461 ec30b191f0e3
parent 1544 2228ea3f6b79
permissions -rw-r--r--
complibs/ppl: build only C and C++ interfaces for PPL

By default, PPL wants to build interfaces for any of a variety of
langauges it finds on the local host (python, java, possibly perl, also
more esoteric languages such as ocaml and prolog).

These extra interfaces can double the compile time for the library. For
single-process builds, I found a savings of more than 40%:

default / j1: 716s total, 143.2s avg, 0.52s stdev
just_c / j1: 406s total, 81.2s avg, 0.33s stdev
just_c_cpp / j1: 413s total, 82.6s avg, 0.22s stdev

And for multi-process builds, it approached 50%:

default / j4: 625s total, 125.0s avg, 0.57s stdev
just_c / j4: 338s total, 67.6s avg, 1.25s stdev
just_c_cpp / j4: 327s total, 65.4s avg, 0.36s stdev

Since the PPL we build within ct-ng is only used by GCC, we only need to
build the C and C++ interfaces.

Signed-Off-By: Anthony Foiani <anthony.foiani@gmail.com>
yann@1393
     1
diff -durN gcc-4.4.0.orig/gcc/c-common.c gcc-4.4.0/gcc/c-common.c
yann@1393
     2
--- gcc-4.4.0.orig/gcc/c-common.c	2009-03-30 19:42:27.000000000 +0200
yann@1393
     3
+++ gcc-4.4.0/gcc/c-common.c	2009-05-27 21:38:08.000000000 +0200
yann@1393
     4
@@ -301,7 +301,7 @@
yann@1393
     5
 /* Warn about format/argument anomalies in calls to formatted I/O functions
yann@1393
     6
    (*printf, *scanf, strftime, strfmon, etc.).  */
yann@1393
     7
 
yann@1393
     8
-int warn_format;
yann@1393
     9
+int warn_format = 1;
yann@1393
    10
 
yann@1393
    11
 /* Warn about using __null (as NULL in C++) as sentinel.  For code compiled
yann@1393
    12
    with GCC this doesn't matter as __null is guaranteed to have the right
yann@1393
    13
diff -durN gcc-4.4.0.orig/gcc/c.opt gcc-4.4.0/gcc/c.opt
yann@1393
    14
--- gcc-4.4.0.orig/gcc/c.opt	2009-03-18 22:14:53.000000000 +0100
yann@1393
    15
+++ gcc-4.4.0/gcc/c.opt	2009-05-27 21:38:08.000000000 +0200
yann@1393
    16
@@ -236,7 +236,7 @@
yann@1393
    17
 Warn about format strings that contain NUL bytes
yann@1393
    18
 
yann@1393
    19
 Wformat-security
yann@1393
    20
-C ObjC C++ ObjC++ Var(warn_format_security) Warning
yann@1393
    21
+C ObjC C++ ObjC++ Var(warn_format_security) Init(1) Warning
yann@1393
    22
 Warn about possible security problems with format functions
yann@1393
    23
 
yann@1393
    24
 Wformat-y2k
yann@1393
    25
diff -durN gcc-4.4.0.orig/gcc/doc/invoke.texi gcc-4.4.0/gcc/doc/invoke.texi
yann@1393
    26
--- gcc-4.4.0.orig/gcc/doc/invoke.texi	2009-04-01 09:18:47.000000000 +0200
yann@1393
    27
+++ gcc-4.4.0/gcc/doc/invoke.texi	2009-05-27 21:38:08.000000000 +0200
yann@1393
    28
@@ -2867,6 +2867,9 @@
yann@1393
    29
 @option{-Wformat-nonliteral}, @option{-Wformat-security}, and
yann@1393
    30
 @option{-Wformat=2} are available, but are not included in @option{-Wall}.
yann@1393
    31
 
yann@1393
    32
+NOTE: In Gentoo, this option is enabled by default for C, C++, ObjC, ObjC++.
yann@1393
    33
+To disable, use @option{-Wformat=0}.
yann@1393
    34
+
yann@1393
    35
 @item -Wformat-y2k
yann@1393
    36
 @opindex Wformat-y2k
yann@1393
    37
 @opindex Wno-format-y2k
yann@1393
    38
@@ -2920,6 +2923,11 @@
yann@1393
    39
 in future warnings may be added to @option{-Wformat-security} that are not
yann@1393
    40
 included in @option{-Wformat-nonliteral}.)
yann@1393
    41
 
yann@1393
    42
+NOTE: In Gentoo, this option is enabled by default for C, C++, ObjC, ObjC++.
yann@1393
    43
+To disable, use @option{-Wno-format-security}, or disable all format warnings
yann@1393
    44
+with @option{-Wformat=0}.  To make format security warnings fatal, specify
yann@1393
    45
+@option{-Werror=format-security}.
yann@1393
    46
+
yann@1393
    47
 @item -Wformat=2
yann@1393
    48
 @opindex Wformat=2
yann@1393
    49
 @opindex Wno-format=2