patches/glibc/2.3.6/260-csu-Makefile.patch
author "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
Sun Jan 25 17:53:14 2009 +0000 (2009-01-25)
changeset 1150 218f7a0e8d71
parent 495 276501e872e5
permissions -rw-r--r--
On 20090120.2203+0100, Andy Johnson <ajohnson@aecno.com> wrote:
The glibc.sh script doesn't handle the glibc versions with
an underscore very well (bash expected integer error). I
have attached a small patch for that. Instead of looking
for "not period" I changed the sense to look for numbers.
I initially tried to make it look for either a period or
an underscore, but that didn't work like I wanted (probably
because I did something wrong).

Original patch modified to be more robust.

/trunk/scripts/build/libc/glibc.sh | 8 4 4 0 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
     1 Use printf instead of echo for some shells.
     2 
     3 http://www.cygwin.com/ml/libc-alpha/2005-02/msg00123.html
     4 
     5 This patch does not generate invalid csu/version-info.h which has
     6 unterminating " line because some /bin/sh cannot parse correctly.  The
     7 previous discussion was:
     8 
     9 	http://sources.redhat.com/ml/libc-alpha/2004-08/msg00129.html
    10 	http://sources.redhat.com/ml/libc-alpha/2004-08/msg00145.html
    11 
    12 This patch gets rid of all this issue because the conclusion of the
    13 discussion was to use printf instead of echo.  Roland, could you look
    14 at it again?
    15 
    16 Regards,
    17 -- gotom
    18 
    19 2005-02-26  GOTO Masanori  <gotom@debian.or.jp>
    20 
    21 	* csu/Makefile: Use printf instead of echo for some shells.
    22 
    23 Index: csu/Makefile
    24 ===================================================================
    25 RCS file: /cvs/glibc/libc/csu/Makefile,v
    26 retrieving revision 1.75
    27 diff -u -p -r1.75 Makefile
    28 --- glibc/csu/Makefile	3 Jan 2005 17:57:14 -0000	1.75
    29 +++ glibc.new/csu/Makefile	27 Feb 2005 01:17:49 -0000
    30 @@ -241,7 +241,7 @@ $(objpfx)version-info.h: $(common-objpfx
    31  	 esac; \
    32  	 files="$(all-Banner-files)";				\
    33  	 if test -n "$$files"; then				\
    34 -	   echo "\"Available extensions:\\n\"";			\
    35 +	   printf '"Available extensions:\\n"\n';		\
    36  	   sed -e '/^#/d' -e 's/^[[:space:]]*/	/'		\
    37  	       -e 's/^\(.*\)$$/\"\1\\n\"/' $$files;		\
    38  	 fi) > $@T
    39