patches/binutils/2.17/180-psignal.patch
author "Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com>
Wed Jun 08 15:47:43 2011 +0200 (2011-06-08)
changeset 2508 9e2761e59a75
parent 745 e445c00d134d
permissions -rw-r--r--
debug/cross-gdb: check host dependencies

Cross-gdb depends on expat and python. If either is missing, cross-gdb will
build successfully, but lacking some features.

Especially, if expat is missing, cross-gdb will be unable to parse the target
description, which may lead to runtime malfunctions and the following GDB
warning:
"Can not parse XML target description; XML support was disabled at compile time"

Hence, expat should be considered mandatory.

On the other hand, the features missing without python are not critical, so
python should not be considered mandatory.

This patch does the following:
- At configure time, warn the user if either expat or python is missing.
- In menuconfig, disable the static build options regarding cross-gdb if no
static version of expat is available, and disable cross-gdb if expat is
missing.

Signed-off-by: "Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com>
[yann.morin.1998@anciens.enib.fr: add comment for impossible static cross-gdb]
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
     1 Make psignal prototype in libiberty match that in glibc.
     2 
     3 Fixes:
     4 
     5 gcc-2.95.3-glibc-2.1.3/binutils-2.15/libiberty/strsignal.c: In function `psignal':
     6 gcc-2.95.3-glibc-2.1.3/binutils-2.15/libiberty/strsignal.c:563: argument `signo' doesn't match prototype
     7 /usr/include/signal.h:131: prototype declaration
     8 gcc-2.95.3-glibc-2.1.3/binutils-2.15/libiberty/strsignal.c:563: argument `message' doesn't match prototype
     9 /usr/include/signal.h:131: prototype declaration
    10 gcc-2.95.3-glibc-2.1.3/binutils-2.15/libiberty/strsignal.c:568: warning: comparison between signed and unsigned
    11 mprotect... make[1]: *** [strsignal.o] Error 1
    12 make[1]: Leaving directory `/export/hda3/dkegel/queue/jobdir.produser_cpsm17/crosstool-0.32/build/i686-unknown-linux-gnu/gcc-2.95.3-glibc-2.1.3/build-binutils/libiberty'
    13 make: *** [all-libiberty] Error 2
    14 
    15 when building on red hat 7.1
    16 though it's a bit of a mystery why libiberty's psignal is being compiled at
    17 all, since red hat 7.1's glibc supports psignal (hence the error message)
    18 
    19 --- binutils-2.17/libiberty/strsignal.c.old	2005-04-18 13:57:40.000000000 -0700
    20 +++ binutils-2.17/libiberty/strsignal.c	2005-04-18 13:59:09.000000000 -0700
    21 @@ -536,7 +536,7 @@
    22  
    23  /*
    24  
    25 -@deftypefn Supplemental void psignal (unsigned @var{signo}, char *@var{message})
    26 +@deftypefn Supplemental void psignal (int @var{signo}, const char *@var{message})
    27  
    28  Print @var{message} to the standard error, followed by a colon,
    29  followed by the description of the signal specified by @var{signo},