binutils/binutils: do not fwd declare struct stat (2.22).
For canadian cross to host i686-mingw32 fwd declaring
struct stat is not possible.
Instead #include <sys/stat.h>
Signed-off-by: Titus von Boxberg <titus@v9g.de>
Message-Id: <417a15d4277913841ddd.1353100974@tschetwerikow.boxberg.lan>
Patchwork-Id: 199733
1 http://bugs.gentoo.org/250342
2 http://sources.redhat.com/bugzilla/show_bug.cgi?id=9685
4 we cant assume sock_cloexec and pipe2 are bound together as the former defines
5 are found in glibc only while the latter are a combo of kernel headers and
6 glibc. so if we do a runtime detection of SOCK_CLOEXEC, but pipe2() is a stub
7 inside of glibc, we hit a problem. for example:
14 if (!popen("ls", "r"))
18 getgrnam() will detect that the kernel supports SOCK_CLOEXEC and then set both
19 __have_sock_cloexec and __have_pipe2 to true. but if glibc was built against
20 older kernel headers where __NR_pipe2 does not exist, glibc will have a ENOSYS
21 stub for it. so popen() will always fail as glibc assumes pipe2() works.
23 diff -durN glibc-2.10.1.orig/include/unistd.h glibc-2.10.1/include/unistd.h
24 --- glibc-2.10.1.orig/include/unistd.h 2008-07-27 20:23:17.000000000 +0200
25 +++ glibc-2.10.1/include/unistd.h 2009-11-13 00:50:15.000000000 +0100
27 extern int __pause_nocancel (void) attribute_hidden;
29 extern int __have_sock_cloexec;
30 -/* At lot of other functionality became available at the same time as
31 - SOCK_CLOEXEC. Avoid defining separate variables for all of them
32 - unless it is really necessary. */
33 -#define __have_pipe2 __have_sock_cloexec
34 +extern int __have_pipe2;
37 diff -durN glibc-2.10.1.orig/socket/have_sock_cloexec.c glibc-2.10.1/socket/have_sock_cloexec.c
38 --- glibc-2.10.1.orig/socket/have_sock_cloexec.c 2008-07-25 18:46:23.000000000 +0200
39 +++ glibc-2.10.1/socket/have_sock_cloexec.c 2009-11-13 00:50:15.000000000 +0100
41 Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
45 #include <sys/socket.h>
46 #include <kernel-features.h>
48 #if defined SOCK_CLOEXEC && !defined __ASSUME_SOCK_CLOEXEC
49 int __have_sock_cloexec;
52 +#if defined O_CLOEXEC && !defined __ASSUME_PIPE2